Add setOnFlushError method to BraintrustState and HTTPBackgroundLogger#1515
Closed
colinbennettbrain wants to merge 3 commits intomainfrom
Closed
Add setOnFlushError method to BraintrustState and HTTPBackgroundLogger#1515colinbennettbrain wants to merge 3 commits intomainfrom
colinbennettbrain wants to merge 3 commits intomainfrom
Conversation
Contributor
colinbennettbrain
commented
Mar 6, 2026
colinbennettbrain
commented
- Added setOnFlushError method to BraintrustState and HTTPBackgroundLogger to manage error callbacks during log flushing.
- Updated login, initLogger, and initExperiment functions to accept and set the onFlushError callback.
- Enhanced tests in logger-misc.test.ts to verify the correct wiring of the onFlushError callback during logger initialization and login processes.
…rwritten by SDK defaults in the TypeScript SDK's ObjectFetcher.fetchRecordsFromApi().
- Added `setOnFlushError` method to `BraintrustState` and `HTTPBackgroundLogger` to manage error callbacks during log flushing. - Updated `login`, `initLogger`, and `initExperiment` functions to accept and set the `onFlushError` callback. - Enhanced tests in `logger-misc.test.ts` to verify the correct wiring of the `onFlushError` callback during logger initialization and login processes.
Member
|
Would you mind sharing the use-case behind this change? IMO the onFlushError on initLogger is already more than powerful enough to cover any use-case I could think of. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If this PR is still relevant, please leave a comment, push an update, or remove the stale label. Thank you for your contributions! |
|
This pull request was closed because it has been inactive for 21 days (14 days of inactivity before being marked stale, plus 7 additional days). If this PR is still relevant, please feel free to reopen it. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.